fix: replace deprecated absoluteFillObject in ActivityIndicator#4890
Open
dhanushpani wants to merge 1 commit intocallstack:mainfrom
Open
fix: replace deprecated absoluteFillObject in ActivityIndicator#4890dhanushpani wants to merge 1 commit intocallstack:mainfrom
dhanushpani wants to merge 1 commit intocallstack:mainfrom
Conversation
|
Hey @dhanushpani, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StyleSheet.absoluteFillObjectwithStyleSheet.absoluteFillin ActivityIndicatorcomponent
loading={true}on React Native 0.85+Bug
On RN 0.85,
StyleSheet.absoluteFillObjectis deprecated. This causes the two half-circle layers inActivityIndicatorto stack vertically instead of overlapping, resulting in two visible spinners.Fix
Replaced
StyleSheet.absoluteFillObjectwithStyleSheet.absoluteFillinsrc/components/ActivityIndicator.tsx. Both resolve to the same styles (position: absolute, top/left/bottom/right: 0), butabsoluteFillis the supported API.Test plan
Buttonwithloading={true}shows a single spinner